GBS
Refactoring Notes
Subprogram basic_mod::input
to be moved in the correct place
Subprogram basic_mod::input_file
to be moved in the correct place
Subprogram basic_mod::mpi_env
to be moved in the correct place
Subprogram diagnose_mod::endrun
Seems more error prone than not doing anything at all...
Subprogram input_reader_mod::check_input_consistency (input)
to be refactored
Subprogram numerics_mod::no_boussinesq_vorticity_terms
Management of ghosts is ad-hoc, lots of communication, lots of copy-pasted code
Subprogram run_controller_mod::control_run ()
Auxval timers are now useless, should time initialize_modules instead.
Subprogram sources_mod::initialize_sources (input_model)
The {omega,vpar[ei]}_source* arrays are currently allocated and initialized but do not enter the RHS equation modules.
Subprogram space_grid_mod::set_zgrid (mpi_env)
This should be checked at the beginning of the run
Subprogram verification_mod::save_errors (fidres, iord3d)
This routine is an output routine. It would be a better fit inside the diagnose_mod module.